https://bugzilla.redhat.com/show_bug.cgi?id=2133551



--- Comment #12 from Fabio Valentini <[email protected]> ---
Thanks! I appreciate the work you've put into this.
I am travelling until ~this Sunday, so I will not be able to get to it until
Sunday or Monday.

After just a quick glance at the spec file I see no obvious show-stoppers from
a Rust POV (other than License tag not taking into account statically linked
Rust deps), so if somebody else wants to review the package before I get to it,
that's fine with me.

For the license stuff, I recommend to use the %cargo_license macro to generate
the license breakdown, and %cargo_license_summary to list the individual
licenses of all components that end up linked into shipped binaries. For a
usage example, you can look at the spec file for rust-rpm-sequoia (or any other
Rust application that has been updated in the last few months).

I'm planning to document these macros in the Rust Packaging Guidelines ASAP
(after applying a small but necessary fix to make them work with %bcond check
being disabled).


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2133551
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to