https://bugzilla.redhat.com/show_bug.cgi?id=2187780



--- Comment #4 from Fabio Valentini <[email protected]> ---
(In reply to blinxen from comment #2)
> Taking this review

Not sure why I didn't get an email notification for your updates ... sorry for
the slow reply.

> General comments:
> 
> - Package was generated with rust2rpm and a manual change was applied
> - Tests were deactivated because of a missing dependency. Should be fine but
> it would be cooler

Yeah, I'm already packaging the missing stuff, but it's not high priority for
me.

> - Some features were deactivated because of dependencies that have limited
> arch support. I guess this is fine to keep this package `noarch` if the
> features are not needed.

Yep, the features aren't needed, and I'd rather not open the can of worms that
is "depending on an unmaintained fork of an OpenSSL fork" ...

> Issues:
> 
> - Apache license contains no year / owner -->
> https://github.com/bluejekyll/trust-dns/blob/main/crates/recursor/LICENSE-
> APACHE#L189

This is in the "How to apply this license to your project" APPENDIX section,
it's normal.

> - rpmlint errors (E: summary-too-long), see below

Ok, good point, I'll trim the Summary a bit.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2187780
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to