https://bugzilla.redhat.com/show_bug.cgi?id=2208350
--- Comment #8 from Phil Wyett <[email protected]> --- Spec URL: https://kathenas.fedorapeople.org/development/fedora/rawhide/for_review/belr/belr.spec SRPM URL: https://kathenas.fedorapeople.org/development/fedora/rawhide/for_review/belr/belr-5.2.45-1.fc39.src.rpm > The .spec files looks good. After looking through the review.txt file, The > problem about license was found. Like the > file of > https://gitlab.linphone.org/BC/public/belr/-/blob/master/cmake/BelrConfig.cmake.in > which produces BelrConfig.cmake > file seemed to be licensed under GPL-2.0-or-later. Can you check the license > again? Good catch. Also found a number of other cmake files under GPL 2, so added to license field. > Another question is about small CLI. I would suggest that making a > sub-package named `belr-tool` or `belr-tools` to include > binary tool files of `belr-compile, belr-parse, belr_tester`. A good idea and done, but have put as 'Recommends' to be installed as a weak dependency by default on -devel unless a user specifically configures their system not to install weak dependencies. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2208350 _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
