https://bugzilla.redhat.com/show_bug.cgi?id=2209850



--- Comment #1 from Michal Josef Spacek <[email protected]> ---
Hi Charles,

There are some issues:
1) We not need line "Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl}
-V:version`"; echo $version))"
BTW: When you look at REQUIRES field in your version of a final package you
could see doubled "perl(:MODULE_COMPAT_5.36.1)", one is autogenerated, and
second from you.
2) You could remove all Requires fields, that are autogenerated by
perl-generators. And Exporter with version is autogenerated too because the
version is placed in code.
BTW: You could check this in REQUIRES field
3) You need to add coreutils to BuildRequires because there is the usage of
chmod in %{_fixperms} macro
4) There is missing BuildRequire for File::Spec which is used in Build.PL

Optional:
We are recommending writing BuildRequires with sections (build, runtime, and
test) and comment each section. Like
https://src.fedoraproject.org/rpms/perl-HTTP-Cookies/blob/rawhide/f/perl-HTTP-Cookies.spec
. This is better to understand what BuildRequire is from which activity.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2209850
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to