https://bugzilla.redhat.com/show_bug.cgi?id=2209067
--- Comment #4 from Jitka Plesnikova <[email protected]> --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok FIX: Add build-require - coreutils - it is needed for %{_fixperms} - perl(strict) - File-Inplace-0.20/lib/File/Inplace.pm:2 FIX: Remove duplicate dependency 'perl(File::Copy)' TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76 NO_PACKLIST is provided since this version. $ rpm -qp --requires perl-File-Inplace-0.20-32.fc39.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(Carp) 1 perl(File::Basename) 1 perl(File::Copy) 1 perl(File::Temp) 1 perl(IO::File) 1 perl(IO::Handle) 1 perl-libs 1 perl(strict) Binary requires are Ok. $ rpm -qp --provides perl-File-Inplace-0.20-32.fc39.noarch.rpm | sort | uniq -c 1 perl(File::Inplace) = 0.20 1 perl-File-Inplace = 0.20-32.fc39 Binary provides are Ok. $ rpmlint ./perl-File-Inplace* ================================== rpmlint session starts ================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 === 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.7 s === Rpmlint is ok FIX: Explicitly name packaged files in %{_mandir}/man* and %{perl_vendorlib} directories https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new spec file. Resolution: Not Approved -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2209067 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202209067%23c4 _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
