https://bugzilla.redhat.com/show_bug.cgi?id=2216297

Fabio Valentini <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
           Doc Type|---                         |If docs needed, set a value



--- Comment #1 from Fabio Valentini <[email protected]> ---
Hm, this crate is going to be problematic:

The dependency on "python" is not good, since this resolves to
"python-unversioned-command", which should no longer be used. However, the
source code explicitly spawns "python" processes, so this would likely need to
be patched in all places to spawn "python3" instead (or patch out the
"spawn_python()" functions in "src/repl.rs"). Though looking at the source
code, I'm almost certain that most of this stuff is never going to be used
anyway (I doubt that anything will try to spawn a PowerShell REPL on Linux).

Additionally, the "Requires: python" (which should be "python3" as well) is
ending up in a void, since it does not apply to any sub-package that's being
built. You'd need to move it to the "-devel" subpackage for it to have the
desired effect.

However, looking at this weird crate, and the fact that it's likely only going
to be used for running some tests, I'd drop the dependency and the tests that
use it. It appears that only the gix-prompt crate would be affected?


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2216297

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202216297%23c1
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to