Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=674587 Mohammed Morsi <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] AssignedTo|[email protected] |[email protected] Flag| |fedora-review? --- Comment #1 from Mohammed Morsi <[email protected]> 2011-02-02 14:54:03 EST --- Will take this one. The package builds fine in koji. Most review guidelines pass except for the following * URL and Source0 are wrong, still referring to the sqlite3-ruby package ones, please update to new locations: http://rubygems.org/gems/sqlite3 * you can remove the BuildRoot tag and the "rm -rf %{buildroot}" at the beginning of %install * please change "%define ruby_sitearch" to "%global ruby_sitearch" at the top of the spec file * rpmlint looks good > $ rpmlint rpmbuild/RPMS/x86_64/rubygem-sqlite3-* > rpmbuild/SRPMS/rubygem-sqlite3-1.3.3-1.fc14.src.rpm > rubygem-sqlite3.x86_64: I: enchant-dictionary-not-found en_US Can be ignored > rubygem-sqlite3.x86_64: W: obsolete-not-provided rubygem-sqlite3-ruby Believe this is what we intend and can be ignored. > rubygem-sqlite3-doc.x86_64: W: unexpanded-macro > /usr/lib/ruby/gems/1.8/doc/sqlite3-1.3.3/ri/SQLite3/Database/authorizer%3d-i.yaml > %3d Can be ignored > rubygem-sqlite3.src:22: W: unversioned-explicit-obsoletes rubygem-sqlite3-ruby I believe we can ignore this as we should retire the rubygem-sqlite3-ruby package after this. Everything else looks good. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
