https://bugzilla.redhat.com/show_bug.cgi?id=2091916



--- Comment #2 from Dominik 'Rathann' Mierzejewski <[email protected]> ---
(In reply to Jakub Kadlčík from comment #1)
> I am trying to build the package but it fails because of a missing
> dependency on python3-pytest. I tried to add it but then it still
> doesn't build because of some failed tests. It will need some
> debugging.

Fixed.

> > # main package is archful to run tests everywhere but produces noarch 
> > packages
> > %global debug_package %{nil}
> 
> Every python package that I have seen so far, had 
> 
>     BuildArch: noarch
> 
> instead of this. Can you please help me understand what is different
> in this case and why we want to do it this way?

In my opinion, other packages should do the same. If the main package is noarch
then it gets built on only one (random) arch and the tests run on only one arch
instead of all Fedora supported ones.

[...]
> I think it would be more helpful to condense here the Features section
> from readme.md or to use the description (or its modified version)
> from setup.py.

Fixed.

Spec URL:
https://rathann.fedorapeople.org/review/python-oscrypto/python-oscrypto.spec
SRPM URL:
https://rathann.fedorapeople.org/review/python-oscrypto/python-oscrypto-1.3.0-2.fc38.src.rpm

* Thu Jun 29 2023 Dominik Mierzejewski <[email protected]> 1.3.0-2
- use pyproject macros and drop explicit BR: on setuptools
- improve description
- run only non-network tests


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2091916

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202091916%23c2
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to