https://bugzilla.redhat.com/show_bug.cgi?id=2208361
Link Dupont <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #2 from Link Dupont <[email protected]> --- - [x] The spec file is clear and easy to read - [x] License is correct - [x] Builds successfully in mock - [x] Package is installable (checked by fedora-review) - [x] No rpmlint errors (or valid justification for exceptions) - [x] %check section passes - [x] The latest version is packaged - [x] %goipath is set correctly - [x] The package complies with the Packaging Guidelines rpmlint detected a couple of .gitignore files that get included when the examples are packaged. > golang-github-iovisor-gobpf-devel.noarch: E: version-control-internal-file > /usr/share/doc/golang-github-iovisor-gobpf-devel/examples/bcc/perf/.gitignore > golang-github-iovisor-gobpf-devel.noarch: E: version-control-internal-file > /usr/share/doc/golang-github-iovisor-gobpf-devel/examples/tracepipe/.gitignore Maybe remove them during %prep? > %prep > %goprep > %autopatch -p1 > rm examples/bcc/perf/.gitignore > rm examples/tracepipe/.gitignore Package approved; consider making the change above on or after import. On import, don't forget to do the following: - [ ] Add package to https://release-monitoring.org - [ ] Add package to https://koschei.fedoraproject.org/packages - [ ] Grant @go-sig group commit privileges on package - [ ] Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2208361 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202208361%23c2 _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
