https://bugzilla.redhat.com/show_bug.cgi?id=2217257



--- Comment #21 from Sandro <[email protected]> ---
Regarding your questions / requests:

b) I've been down that road before. There's multiple things to consider:

I) PyPI parity:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_pypi_parity
II) Primary use of the package (library vs. utility / app):
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_library_naming
vs.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_application_naming
III) Provides and requirements:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_provides_and_requirements

I) is not relevant. The package is registered on PyPI as 'nihtest'. Regarding
II) the package provides an application but also a library. In this case I find
it hard to say which is prevalent. I'd say both depend on each other. The app
requires the library, but one may also import the library to extend it etc.
That's why I opted for providing 'nihtest' as a virtual sub package. From a
packaging approach, I find it easier than the other way around. By providing
'nihtest' a user can simply install with 'dnf install nihtest' if in need of
the app.

c) I added the '%{?_smp_mflags}' macro to the make command.

Updated sources:

Spec URL:
https://download.copr.fedorainfracloud.org/results/gui1ty/reviews/fedora-rawhide-x86_64/06155317-python-nihtest/python-nihtest.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/gui1ty/reviews/fedora-rawhide-x86_64/06155317-python-nihtest/python-nihtest-1.1.1-2.fc39.src.rpm


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2217257

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202217257%23c21
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to