https://bugzilla.redhat.com/show_bug.cgi?id=2227433

Robert-André Mauchin 🐧 <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
           Assignee|[email protected]    |[email protected]
             Status|NEW                         |ASSIGNED
              Flags|                            |fedora-review?



--- Comment #2 from Robert-André Mauchin 🐧 <[email protected]> ---
Why don't you use :

%generate_buildrequires
%go_generate_buildrequires

instead of :

%if %{with check}
# Tests
BuildRequires:  golang(git.sr.ht/~nelsam/hel/pkg/pers)
BuildRequires:  golang(git.sr.ht/~nelsam/hel/vegr)
BuildRequires:  golang(github.com/fatih/color)
%endif


 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Go Packaging Guidelines


Please check what I said above and I'll approve.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2227433

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202227433%23c2
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to