https://bugzilla.redhat.com/show_bug.cgi?id=2227434

Robert-André Mauchin 🐧 <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Doc Type|---                         |If docs needed, set a value
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review?
                 CC|                            |[email protected]



--- Comment #1 from Robert-André Mauchin 🐧 <[email protected]> ---
I'd suggest you rename your package to 'hel'.

I don't think you need the library files either, so you could get rid of :

%gopkg

%gopkginstall

%gopkgfiles


and just keep the binary.


> {_bindir}/*

Please specify the binary name instead of a glob:

{_bindir}/hel




 - License ok
 - Latest version packaged
 - Builds in mock
 - Checks pass
 - No rpmlint errors
 - Conforms to Go Packaging Guidelines


Please take into account my comments and get back to me with a needinfo.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2227434

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202227434%23c1
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to