Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675104

Pavel Zhukov <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #1 from Pavel Zhukov <[email protected]> 2011-02-04 13:20:06 EST ---
A few comments
- There's also no need to use %{__rm}  for rm command, although there is
currently no guideline forbidding it. 
- you've removed BuildRoot section, so you can't push package to EPEL but you
haven't removed %clean section (it is not required for F-13 and above
http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean)
- you should point setuptools in BuildRequired. Because koji build is failed.



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to