https://bugzilla.redhat.com/show_bug.cgi?id=2231007
Fabio Valentini <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Status|NEW |ASSIGNED Assignee|[email protected] |[email protected] Flags| |fedora-review? --- Comment #3 from Fabio Valentini <[email protected]> --- Two quick comments: 1. If you disable the %check bcond, then un-pinning trybuild is not necessary. dev-dependencies are not included in generated BuildRequires when the check bcond is turned off. So you can just drop the patch in this case. 2. "rm -rf Cargo.lock" in %prep looks weird, and should be unnecessary. The %cargo_prep macro should already do this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2231007 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202231007%23c3 _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
