https://bugzilla.redhat.com/show_bug.cgi?id=2231205

Robert-André Mauchin 🐧 <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[email protected]          |[email protected]
                 CC|                            |[email protected]
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+



--- Comment #5 from Robert-André Mauchin 🐧 <[email protected]> ---
Yeah sorry about that, I pushed the wrong otel package the other, asked releng
to untag it, but then the previous package was not tagged for F40/F39, so
otel-0.20 took over. I asked releng to fix it Sunday morning, and it was fixed
later that day.


Clean up this every time you use go2rpm:

%global golicenses      LICENSE github/licenses.go github/licenses_test.go
%global godocs          example AUTHORS CONTRIBUTING.md README.md example\\\
                        scrape/README.md
->

%global golicenses      LICENSE
%global godocs          example AUTHORS CONTRIBUTING.md README.md


%license LICENSE github/licenses.go github/licenses_test.go
%doc example AUTHORS CONTRIBUTING.md README.md example scrape/README.md

->

%license LICENSE
%doc example AUTHORS CONTRIBUTING.md README.md




Are you sure you need this package? We have golang-github-google-go-github at
version 53 in Fedora:

# Generated by go2rpm 1.9.0
# Needs network
%bcond_with check
%global debug_package %{nil}

# https://github.com/google/go-github
%global goipath         github.com/google/go-github
Version:                53.1.0

%gometa

%global goname golang-github-google-go-github

%global goaltipaths     github.com/google/go-github/v53



What I do in most package is switch the import path so it depends on the Fedora
Package:


sed -i 's|github.com/google/go-github/v35|github.com/google/go-github|' $(find
. -iname '*.go' -type f)



Usually it works, so unless you need that very specific version, I'd recommend
against packaging it.


- License ok
- Latest version packaged
- Builds in mock
- Checks pass
- No rpmlint errors
- Conforms to Go Packaging Guidelines

Package approved.

Please:
 - add commit rights to go-sig after requesting the repo
 - add the package to Koschei in the go-sig group on all branches you are
building
 - add the package to release-monitoring.org even if it does not release
version


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2231205

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202231205%23c5
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to