https://bugzilla.redhat.com/show_bug.cgi?id=2231107
--- Comment #10 from Maxwell G <[email protected]> --- This looks pretty good to me. A couple minor comments: - Please remove the unit test stuff entirely. The upstream project does not use ansible-test to run collection unit tests. Having it there but disabled is confusing and just adds clutter to the specfile. - You have a bunch of trailing spaces in the second line of %description. - There are also trailing spaces in %install. - You should use `%doc awx_collection_build/README.md` instead of `%doc README.md`. We're interested in the collection not AWX itself. - The License should be `GPL-3.0-or-later` not `GPL-3.0-only`. The collection's README says: > All content in this folder is licensed under the same license as Ansible, > which is the same as the license that applied before the split into an > independent collection. Ansible is licensed under `GPL-3.0-or-later`, and some of the files have GPLv3+ headers. Thanks for working on this, Andrew, and thanks for reviewing this, Kevin! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2231107 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202231107%23c10 _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
