https://bugzilla.redhat.com/show_bug.cgi?id=2237982

José Matos <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review+



--- Comment #2 from José Matos <[email protected]> ---
Review notes:

* Package follows packaging guidelines (it is a simple python package and
macros do most of the work) :-)
* Package builds and installs properly
* Package licensing is correct and license files are collected

There are two remarks to do regarding the license:
1) rpmlint complains:
python3-inkex.noarch: E: incorrect-fsf-address
/usr/lib/python3.12/site-packages/inkex-1.3.0.dist-info/LICENSE.txt

so basically the address of FSF is outdated. This issue needs to be fixed in
the upstream project and not here, please warn them.

2) The license file is packaged but not marked as such:
  Note: License file LICENSE.txt is not marked as %license
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/LicensingGuidelines/#_license_text

Fix this on import.

Otherwise, this is good to go...

PACKAGE APPROVED.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2237982

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202237982%23c2
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to