https://bugzilla.redhat.com/show_bug.cgi?id=2235768

Benson Muite <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+
                   |needinfo?(benson_muite@emai |
                   |lplus.org)                  |
             Status|ASSIGNED                    |POST



--- Comment #21 from Benson Muite <[email protected]> ---
Seems ok. A few more warnings from fedora-review:

a) objfw.src: W: strange-permission objfw.spec 600

b) Use QPL-1.0 OR GPL-3.0-only OR GPL-2.0-only

- The License field must be a valid SPDX expression.
  Note: Not a valid SPDX expression 'QPL-1.0 or GPL-3.0-only or
  GPL-2.0-only'.
  See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1

c) doc package needs to be noarch so use
%package doc
Summary:       Documentation for ObjFW
BuildArch:     noarch

%description doc
Documentation for ObjFW.

Please do above on import. Thanks for building this and bringing it to Fedora.

Approved.

If time allows, would appreciate a review of one of:
https://bugzilla.redhat.com/show_bug.cgi?id=2237648
https://bugzilla.redhat.com/show_bug.cgi?id=2218338


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2235768

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202235768%23c21
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to