Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=675705 Michal Fojtik <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #2 from Michal Fojtik <[email protected]> 2011-02-10 04:24:47 EST --- * Packages that contain Ruby Gems must be called rubygem-%{gemname} where gemname is the name from the Gem's specification. OK * The Source of the package must be the full URL to the released Gem archive; the version of the package must be the Gem's version OK * The package must have a Requires and a BuildRequires on rubygems OK * The package must provide rubygem(%{gemname}) where gemname is the name from the Gem's specification. For every dependency on a Gem named gemdep, the package must contain a Requires on rubygem(%{gemdep}) with the same version constraints as the Gem OK * The %prep and %build sections of the specfile should be empty. OK * The Gem must be installed into %{gemdir} defined as %global gemdir %(ruby -rubygems -e 'puts Gem::dir' 2>/dev/null) The install should be performed with the command gem install --local --install-dir %{buildroot}%{gemdir} --force %{SOURCE0} OK * The package must own the following files and directories: %{gemdir}/gems/%{gemname}-%{version}/ %{gemdir}/cache/%{gemname}-%{version}.gem %{gemdir}/specifications/%{gemname}-%{version}.gemspec OK REVIEW+ Small notes about spec: - Please move %{geminstdir}/test to docs - In %check there is pushd but no popd - Consider replace %{_bindir}/tilt with %{_bindir}/%{gemname} - Consider replace %{geminstdir}/tilt.gemspec with %{geminstdir}/%{gemname}.gemspec Please fix those two before pushing this to GIT. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
