https://bugzilla.redhat.com/show_bug.cgi?id=2239462



--- Comment #5 from Charles R. Anderson <[email protected]> ---
Spec URL: https://cra.fedorapeople.org/perl-File-KDBX/perl-File-KDBX.spec
SRPM URL:
https://cra.fedorapeople.org/perl-File-KDBX/perl-File-KDBX-0.906-6.fc40.src.rpm

(In reply to Xavier Bachelot from comment #4)
> - rpmlint complains about :
> perl-File-KDBX.src: W: strange-permission File-KDBX-0.906.tar.gz 640

Fixed.

> - I'm not sure the %{?perl_default_filter} is required ?

It seems good practice to prevent accidental Provides: from %_docdir.

> - I'd drop the last sentence of %description.

OK.

> - It would be nice to at least try to make the optional packages for test
> available in Fedora.

Yes, they are in the queue.  I'll be submitting all optional deps soon.

> - According to tangerine, missing BRs:
> B::COW
> Config
> Errno

Added, thanks.

> TestCommon

This is provided by the package itself:

$ tangerine --mode=package . | tail -2
TestCommon
        PACKAGE t/lib/TestCommon.pm:1


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2239462

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202239462%23c5
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to