https://bugzilla.redhat.com/show_bug.cgi?id=2222844



--- Comment #12 from Artur Frenszek-Iwicki <[email protected]> ---
Hi Ryan, sorry for making you wait so long for a reply.

> %global commit 41e8f84bf68f7bb658430a37b5647c172d86e38e
> %global snapdate 20230828
> 
> Version: %{snapdate}git%(c='%{commit}'; echo "${c:0:7}")
This will produce a package with version "20230828git...".
The recommended way is to use caret-versioning instead: "0^%{snapdate}..."
https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_upstream_has_never_chosen_a_version

> %files
> 
> %files tools
> ...
> 
> %files devel
> ...
A setup like this will result in the build process producing an empty "qoi"
package that contains no files.
Remove the "%files" line - this will make it so the build produces only
qoi-devel and qoi-tools.
You can then drop "Requires: %{name}%{?isa} = %{version}-%{release}" from the
subpackages.

> %files tools
> %license LICENSE
> ...
> %files devel
> 
> %changelog
Since -devel is independent from -tools, and it is possible to install only one
of those packages,
both of them should include a copy of the licence text.
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#subpackage-licensing


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2222844

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202222844%23c12
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to