https://bugzilla.redhat.com/show_bug.cgi?id=2243345

Fabio Valentini <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[email protected]    |[email protected]
             Status|NEW                         |ASSIGNED
              Flags|                            |fedora-review?



--- Comment #6 from Fabio Valentini <[email protected]> ---
(In reply to Colin Walters from comment #5)
> Thanks for the reply!
> 
> Spec URL: https://fedorapeople.org/~walters/bootc.spec
> SRPM URL: https://fedorapeople.org/~walters/bootc-0.1.1-1.fc40.src.rpm

Thanks, I'll take another look tomorrow. It's getting late.

> > PS: Do you have a list of the crates are currently missing from Fedora, 
> > preventing this package from being built without vendored dependencies?
> 
> Biggest is kube, a dependency which I am really debating because it's kind
> of massive overkill for what we need right now.
> Though either way as you know it's important to me to keep this spec in sync
> with C9S.

And I'm sure you know, Keeping the spec file in sync with C9S is an anti-goal,
since different rules apply to Fedora and CentOS Stream.
The current spec file will also not build on ELN / RHEL, since the RHEL macros
for Rust packaging diverge from the Fedora / EPEL macros.
Though it *should* build in epel9-next (i.e. EPEL on top of CentOS Stream 9).

> > (On second glance, it looks like this was adapted from the rust-bootupd 
> > package, which explains the unusual structure and issues with duplicate 
> > License / Summary tags.
> 
> Yes indeed.  Fixed those thanks!

:+1:

> >  Pointing rust2rpm at bootc-0.1.1/Cargo.toml should actually give you 
> > better results than that. :)
> 
> It's a bit messier than that as it's split into sub-crates *internally* but
> I don't want to publish those to crates.io; looks like `cargo package` wants
> that.  I'm sure I could fake it out but...mmm, dunno.

Faking things should not be necessary. rust2rpm has supported cargo workspaces
for a while (and things not published on crates.io for *ages*) - pointing it at
the toplevel Cargo.toml file from the uncompressed source tarball (i.e.
literally "rust2rpm bootc-0.1.1/Cargo.toml") should just do "the right thing"
(C).


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2243345

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202243345%23c6
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to