https://bugzilla.redhat.com/show_bug.cgi?id=2235084
Robert-André Mauchin 🐧 <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?([email protected] |needinfo?(gui1ty@penguinpee |) |.nl) --- Comment #6 from Robert-André Mauchin 🐧 <[email protected]> --- >1. PyPI vs. GitHub > Pypi tarball rarely haves docs or tests, Githb have them. >You are getting the source from GitHub. Is the PyPI tarball not usable? >Since pulling from GitHub, did you consider using forge macros? It makes the >Source URL more readable and saves you from having to construct it yourself. Forge macros are largely unmaintained and generally not recommended. Some woek is being done to streamline them. >2. Documenting changes > >In %prep you modify pyproject.toml and setup.cfg. Could you add a comment >explaining why this is necessary. >For the first edit there might be a cleaner, more readable solution. Or you >could do without it completely using the PyPI source which has the version set. >3. Duplicate license files > >All license files are defined in `license_files` in `setup.cfg`. That means >`%pyproject_save_files` treats them as such and marks them as license files. >Use `rpm -q --licensefiles -p $RPM` to verify. Long story short, you can drop >`%license`. ok >[!]: License file installed when any subpackage combination is installed. > >=> When installing the doc subpackage, no license files are installed. One >solution is to make it require the main package. They literally are: %files -n python-%{pypi_name}-doc %doc html %license NOTICE apache-2.0.LICENSE Thanks for the review! Spec URL: https://eclipseo.fedorapeople.org/for-review/python-typecode.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/python-typecode-30.0.1-1.fc39.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2235084 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202235084%23c6 _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
