https://bugzilla.redhat.com/show_bug.cgi?id=2232861

Tim Semeijn <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #2 from Tim Semeijn <[email protected]> ---
This is an unofficial review as I am not in the packager group yet.

> Package does not contain duplicates in %files.
> Note: warning: File listed twice: /usr/share/java/jsemver
> See: 
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_duplicate_files

This issue seems a false positive as /usr/share/java/jsemver and
/usr/share/maven-poms/jsemver both are folders with the same name but contain
different files. This can be ignored.

> License file ADDITIONAL_LICENSE_INFO is not marked as %license
> See: 
> https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text

File seems to mention additional licensing requirements regarding an exception
to the GPLv2 (GNU Classpath Exception). Please verify how this affects
licensing and if acceptable to use mark it as %license under %files.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2232861

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202232861%23c2
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to