https://bugzilla.redhat.com/show_bug.cgi?id=2251171



--- Comment #4 from İsmail Dönmez <[email protected]> ---
Updated spec file:
https://download.copr.fedorainfracloud.org/results/idoenmez/open-vmdk/fedora-rawhide-x86_64/06697233-open-vmdk/open-vmdk.spec
Updated srpm:
https://download.copr.fedorainfracloud.org/results/idoenmez/open-vmdk/fedora-rawhide-x86_64/06697233-open-vmdk/open-vmdk-0.3.6-1.fc40.src.rpm

> This should be just "Source: 
> %{url}/archive/v%{version}/%{name}-%{version}.tar.gz"
Fixed, thank you!

>This needs to be hard wrapped to 79 columns.
Done.

> Please use "%autosetup -p1" here.
Done.

> If you intend to build this for EPEL, you should add 
> "%{!?_auto_set_build_flags:%{set_build_flags}}" above "%make_build"
Done, but I hope to get this in rawhide and Fedora proper.

>Please add a trailing slash here.
Done.

>This is too greedy, please list out the binaries.
Sigh, I've been lazy, done.

> %config %{_sysconfdir}/*
Done.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2251171

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202251171%23c4
--
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to