Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=678774

--- Comment #4 from Tim Niemueller <[email protected]> 2011-02-20 05:46:22 EST 
---
(In reply to comment #2)
> Why do you move "#include <stdio.h>" in scslib-1.4.1/tests/test_accuracy.c?

Because it is required to get a macro defined in gmp.h, which consequently
makes mpfr_out_str available.

> Suggestion: make "%doc DocsDev/html" to get html subfolder in -devel.

Since the HTML documentation is the only thing packaged as %doc it only adds on
more meaningless level of hierarchy.

> Are the test programs required?

They provide valuable run-time data specific to the host system the application
is running on, therefore they should be shipped with the library afaik.

> One more. libscs-devel must Require mpfr-devel and gmp-devel.

Added.

Spec changed in place, new SRPM is at
http://fedorapeople.org/~timn/misc/libscs-1.4.1-3.fc14.src.rpm.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to