https://bugzilla.redhat.com/show_bug.cgi?id=2250689



--- Comment #4 from Tom Rix <[email protected]> ---
Need to change to newer python guidelines
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/
Unless there is a good reason.
I think this is just using this bit

%build                                                                          
%pyproject_wheel                                                                

%install                                                                        
%pyproject_install                                                              

%py3_shebang_fix %{buildroot}%{python3_sitelib}/untangle.py    

and in %files

%{python3_sitelib}/untangle-%{version}.dist-info  

--
URL:            https://github.com/stchris/untangle                             
Source0:       
https://github.com/stchris/untangle/archive/refs/tags/%{version}.tar.gz#/%{name}-%{version}.tar.gz
 

Source0 can be simplified by use of %{url}

--

My local fedora-review shows this problem in the original 
python3-untangle.noarch: E: non-executable-script
/usr/lib/python3.12/site-packages/untangle.py 644 /usr/bin/env python  
which may be fixed by the shebang_fix line above.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2250689

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202250689%23c4
--
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to