https://bugzilla.redhat.com/show_bug.cgi?id=2256631



--- Comment #6 from Ben Beasley <[email protected]> ---
Thanks for the update. The Summary looks good. You still need to copy the
LICENSE file into the source tree and add it to the %files list so that it is
present in the -devel subpackage.

  %prep
  %autosetup -n %{crate}-%{version} -p1
  cp -p '%{SOURCE1}' .
  %cargo_prep

and

  %files          devel
  %license LICENSE
  %doc %{crate_instdir}/README.md
  %{crate_instdir}/

It wouldn’t hurt to link https://github.com/huggingface/safetensors/pull/416 in
a spec-file comment above the added Source1.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2256631

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202256631%23c6
--
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to