https://bugzilla.redhat.com/show_bug.cgi?id=2259199



--- Comment #7 from Jordan Rome <[email protected]> ---
> - You are using "ExcludeArch: %{ix86}", can you explain why? Just because you 
> don't want to build an application for i686 and it's not a library that can 
> be used by other Rust programs?

This binary currently doesn't build on this architecture and as mentioned in
https://bugzilla.redhat.com/show_bug.cgi?id=2259075 - It's just not worth it to
support it there.

> - Why are you changing the Summary / description? We usually only override 
> those from Cargo.toml metadata if the upstream description is really bad and 
> / or the heuristics for generating a short (<72 characters) summary from a 
> long description string fail. You wrote a whole new description instead. In 
> that case, I would rather update the description in Cargo.toml to be more 
> descriptive and submit that as a PR to upstream.

Yes, I'm going to update the cargo.toml in upstream shortly. Just wanted to get
these fixed up in the meantime. And yeah, the description and summary were
pretty bad :)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2259199

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202259199%23c7
--
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to