https://bugzilla.redhat.com/show_bug.cgi?id=2259838



--- Comment #5 from Adrian Reber <[email protected]> ---
The review tool complains about "[!]: Uses parallel make %{?_smp_mflags}
macro.". It does not make much sense for a Go package but you could still add
"%{?_smp_mflags}" after make.

You could also add a "%check" section and run the test suite.

I am not sure about the `with_debug` logic. Is that needed?


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2259838

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202259838%23c5
--
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to