https://bugzilla.redhat.com/show_bug.cgi?id=1936727

Felix Wang <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #9 from Felix Wang <[email protected]> ---
I will try to review the package.

1.
> # Bundled gtest and python helper scripts are licensed BSD, but not included 
> in installation
> # src/FilesystemBoost.cc is licensed under the Boost Software License 1.0
> # graphics/src/tiny_obj_loader is licensed MIT
> # Remaining files are Apache 2
> License:    ASL 2.0 and Boost and MIT

change the license name to SPDX format

2.
> Source0:    
> https://osrf-distributions.s3.us-east-1.amazonaws.com/ign-common/releases/ignition-common%{abiver}-%{version}.tar.bz2

I suugest use source from its github tag, and update to the latest version.
https://github.com/gazebosim/gz-common/releases/tag/ignition-common3_3.17.0


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1936727

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%201936727%23c9
--
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to