Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=673589 Mamoru Tasaka <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|[email protected] |[email protected] Flag| |fedora-review? --- Comment #29 from Mamoru Tasaka <[email protected]> 2011-02-26 14:33:02 EST --- Almost okay. * Timestamps - Please consider to use --------------------------------------------------------------- make install DESTDIR=%{buildroot} INSTALL="install -p" --------------------------------------------------------------- to keep timestamps also on installed header files. This method usually works for Makefiles generated by recent autotools. ? %check - $ make tests seems to generate example binaries, however these binaries are not packaged into binary rpms, and no actual testsuite is executed. Is %check section really needed? Also please address Ralf's comments. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
