https://bugzilla.redhat.com/show_bug.cgi?id=2268364



--- Comment #3 from Aleksei Bavshin <[email protected]> ---
Spec URL: https://alebastr.fedorapeople.org/review/libscfg.spec
SRPM URL: https://alebastr.fedorapeople.org/review/libscfg-0.1.1-1.fc40.src.rpm

Thanks for the review!

> a) Upstream has a test. Can this be run?

Fixed.

> b) Should pkgconfig be required?  There are a few bugs with the
> fedora-review directory ownership check.


It's already required automatically by pkgconfig dependency generator:

    Requires
    --------
    ...
    libscfg-devel (rpmlib, GLIBC filtered):
       /usr/bin/pkg-config


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2268364

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202268364%23c3
--
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to