https://bugzilla.redhat.com/show_bug.cgi?id=2270340

Arthur Bols <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #2 from Arthur Bols <[email protected]> ---
Hi Adam,

I'm not taking this review as of right now, but to speed up the review process
you can already update the spec to be in line with modern Fedora guidelines.

Here are a couple of things I noticed:
- Use the `%make_build` macro
- Use rpmautospec macros %autorelease and %autochangelog (not required)
- Remove the versioned dependencies if not necessary
- License: field should be a SPDX identifier


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2270340

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202270340%23c2
--
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to