https://bugzilla.redhat.com/show_bug.cgi?id=2251785



--- Comment #8 from Tom Rix <[email protected]> ---
At least the licensecheck seems to be missing from the above auto review.
Spec looks generally fine.

This line should not be needed.
        -DCMAKE_CXX_FLAGS="%{optflags} -Wformat -Wformat-security" \ 

There is also at least third party for 
src/bindings/python/thirdparty
src/plugins/intel_gpu/thirdparty

That needs to be removed.

I think the two small plugin subpackages should be rolled into the the main
package.

There should be a way, even a manual way to test.

The samples/ would be good to include into the devel package.

Can python be enabled ? python is widely used in AI so this would be good.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2251785

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202251785%23c8
--
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to