https://bugzilla.redhat.com/show_bug.cgi?id=2271615



--- Comment #2 from Neal Gompa <[email protected]> ---
Initial spec review:

> %global macrosdir %(d=%{_rpmconfigdir}/macros.d; [ -d $d ] || 
> d=%{_sysconfdir}/rpm; echo $d)

This can be deleted and replaced with "%{_rpmmacrodir}"

> Redict is an independent fork of RedisĀ®* OSS 7.2.4 licensed under the
> Lesser GNU General Public license (LGPL-3.0-only).
> Redict is not affiliated with RedisĀ®.

This needs to be dropped from the description, it's unneeded and unwanted.

> %{macrosdir}/*

This needs to use "%{_rpmmacrodir}" and needs to be less greedy.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2271615

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202271615%23c2
--
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to