https://bugzilla.redhat.com/show_bug.cgi?id=2274950



--- Comment #2 from Jonathan Steffan <[email protected]> ---
(In reply to Davide Cavalca from comment #1)
> - why the ExclusiveArch: x86_64 ?

No specific reason, I've just been focused on x86_64. I removed this.

> - why is it built using clang ?

Just have been using a pattern for all of the stuff I've been working on, of
which a handful require clang. I've updated it to use gcc.

> - consider filing a ticket upstream asking for a new release (and adding it
> as a comment to justify why we're packaging a snapshot)

Done.

> - nit: you should be able to use %forgeautosetup` in %setup` to combine
> forgesetup and autopatch

I've updated this. I had it split for other packages because I needed to patch
after dealing with multiple sources.

Spec URL: https://jsteffan.fedorapeople.org/imrsv/xrgears.spec
SRPM URL:
https://jsteffan.fedorapeople.org/imrsv/xrgears-1.0.1-1.20231207git6376389.fc39/xrgears-1.0.1-1.20231207git6376389.fc39.src.rpm


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2274950

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202274950%23c2
--
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to