https://bugzilla.redhat.com/show_bug.cgi?id=2276949
--- Comment #3 from Ben Beasley <[email protected]> --- (In reply to Fabio Valentini from comment #2) > I'm a little confused - you disable running tests from README.md because you > claim it's not included in published crates - but it is? > > Unpacking reqwest-middleware-0.3.0.crate shows it's in there. The only thing > that's wrong is the path - it should be ../README.md, not ../../README.md > (possibly because this crate is packaged from a subdirectory). Hmm, you’re correct. Normally, the right thing to do would be to carry a downstream-only patch that adjusts include_str!("../../README.md") to include_str!("../README.md") so that we can run the README tests. In this case, I should still patch them out, because they introduce a test dependency on rust-reqwest-retry, and that package is going to have a build dependency on *this* package, so dropping the README tests breaks the bootstrapping loop. However, I need to have a correct comment. I’ll prepare an updated submission. I’ll make rust2rpm take care of the tomcli BR while I’m at it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2276949 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202276949%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
