https://bugzilla.redhat.com/show_bug.cgi?id=2273535

Bryan Gurney <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+
             Status|ASSIGNED                    |POST



--- Comment #16 from Bryan Gurney <[email protected]> ---
I'll approve this, with some notes:

- We need to add "deduplication" to the rpmlint spelling database.

- The "%check" is a "SHOULD" item, not a "MUST" item; at some point, a test
that validates the contents of the package without risking a spurious failure
needs to be added, but we're not there yet, and I don't think it should block
the first Fedora build of this package.

- This user tools package is designed to be used alongside the VDO kernel
module, which was added to the Linux kernel in the 6.9 merge window.  VDO only
works on 64-bit CPU architectures, which is why vdospec has "ExcludeArch:
%{ix86}".  (Originally, VDO was only built for x86_64.)


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2273535

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202273535%23c16
--
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to