https://bugzilla.redhat.com/show_bug.cgi?id=2268627



--- Comment #3 from Petr Menšík <[email protected]> ---
It seems to me that json schemas should belong not to python code path, but
into some %_datadir subdirectory. Similar to moving manual pages, it might move
also schemas to better location. For not required code changes I would
recommend using symlinked files from the code. But it contains at least one
python script, so I have made it acceptable in current configuration.

Also cvelib/schemas/README.md mentions this is actually content from
https://github.com/CVEProject/cve-schema/blob/master/schema/CVE_Record_Format.json

I think it means Provides: bundled(cve-schema) should be used, with version if
it can be obtained. Probably with at least link to github project. It seems too
small to demand separate package for cve-schema upstream package, but that
would be ideal way to implement it.

Because it technically does not use any bundled library, but just bundled
*data*, I have passed review without demanding changes first.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2268627

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202268627%23c3
--
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to