https://bugzilla.redhat.com/show_bug.cgi?id=2280116
--- Comment #15 from Ben Beasley <[email protected]> --- (In reply to Paul Pfeister from comment #14) > Build itself actually succeeds, unit tests just fail when built without > internet access (as done by the review service bot). This is an > internet-reliant tool and the unit tests validate internet-reaching probes. > > tox succeeds in mock or on the copr when internet access is available. Real Fedora builds are always done offline. You’ll need to selectively disable all tests that require network access. If you want to be able to run network tests manually in mock from time to time, you can gate this behind a build conditional, e.g. %bcond network_tests 0 %if %{without network_tests} ... %endif %if %{with network_tests} ... %endif If *all* of the tests really require network access and you have to disable tests entirely, you should at least run an import-only “smoke test” with %pyproject_check_import: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_running_tests -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2280116 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202280116%23c15 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
