https://bugzilla.redhat.com/show_bug.cgi?id=2284159



--- Comment #2 from Neal Gompa <[email protected]> ---
Initial spec review:

> Release:        1

Missing DistTag.

> %if %{with vendor}
> # see create-vendor-tarball.sh in this distgit repo
> Source0:        trayscale-%{version}-vendored.tar.xz
> %else
> Source0:        %{gosource}
> %endif

The script needs to be included as a source so that it's part of the SRPM.

> desktop-file-validate 
> %{buildroot}%{_datadir}/applications/dev.deedles.Trayscale.desktop
> appstream-util validate-relax --nonet 
> %{buildroot}%{_metainfodir}/dev.deedles.Trayscale.metainfo.xml

This should be in %check


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2284159

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202284159%23c2
--
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to