https://bugzilla.redhat.com/show_bug.cgi?id=2208353
Cristian Le <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #7 from Cristian Le <[email protected]> --- > License needs clarification, ambiguity with between spec file and upstream. If I understand correctly you are referring to the pypi showing BSD and spec BSD-3-clause. Comparing BSD-3-clause [1] with LICENSE, it seems the latter is correct. But please make a patch to fix the metadata. But unicode projects seem to very tricky w.r.t. licensing. Afaics, it doesn't use any unicode licensed data, so it should be fine with the current license metadata. The "Unknown or generated" part should be fine since if you look at the whole project, there isn't much there. > It's not clear what is being packaged. The package depends on python3-slugify Actually it doesn't, but it should be marked as `Conflicts`/`Obsoletes` since python3-slugify is effectively dead. Here are some affected packages: ```console $ fedrq wr --branch=rawhide python3-slugify python-agate-1.11.0-1.fc41.src python-cookiecutter-2.6.0-2.fc41.src python-django-uuslug-2.0.0-9.fc41.src python3-agate-1.11.0-1.fc41.noarch python3-cookiecutter-2.6.0-2.fc41.noarch python3-django-uuslug-2.0.0-9.fc41.noarch transifex-client-0.13.7-15.fc41.noarch transifex-client-0.13.7-15.fc41.src ``` > The upstream sources for the package seem to only contain a test suite It also includes `__init__.py` which I think is what's meant to be the main thing packaged. As for having `tests` inside the main package, that is a rather common pattern, even though I personally don't like it. From my side: - would you consider adding the patch: https://github.com/mozilla/unicode-slugify/pull/41 - could you bug upstream to add appropriate tags/releases when they make a pypi release. If they need, they can copy one of my github workflows [2] (although they can simplify the `release.yaml` by adding `pipx run build` instead of calling the other workflows) [1]: https://opensource.org/license/bsd-3-clause [2]: https://github.com/click-contrib/click-option-group/tree/master/.github/workflows -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2208353 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202208353%23c7 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
