https://bugzilla.redhat.com/show_bug.cgi?id=2292665

Jakub Kadlčík <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #8 from Jakub Kadlčík <[email protected]> ---
> # if you are missing somewhere and the dependencies are in fedora, let me 
> know to enable it
> #%%pyproject_extras_subpkg -n python3-huggingface-hub 
> cli,,fastai,hf-transfer,inference,quality,tensorflow,tensorflow-testing,testing,torch,typing

I am not quite sure what you are trying to say here (and in the same
comment bellow). 


> # For official Fedora packages, including files with '*' +auto is not allowed
> # Replace it with a list of relevant Python modules/globs and list extra 
> files in %%files

A leftover autogenerated comment, can be removed


> %check

They have tests in the upstream repository which would be nice to
run. But they are not present in the PyPI tarball. 

If you prefer the PyPI tarball, can you please add a comment in the
%check phase that we are not running the tests because they are not
available there?


Otherwise LGTM


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2292665

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202292665%23c8
--
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to