https://bugzilla.redhat.com/show_bug.cgi?id=2293067

Jakub Kadlčík <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #2 from Jakub Kadlčík <[email protected]> ---
> Issues:
> =======
> - Package contains BR: python2-devel or python3-devel

For some reason, Fedora Review Service didn't pick up on this. Every Python
package needs to depend on python3-devel.


> argparse-manpage --pyfile dist_git_client.py \
>    --function _get_argparser \
>    --author "Copr Team" \
>    --author-email "[email protected]" \
>    --url %url --project-name Copr \

This should probably happen during the %build phase


> %_bindir/dist-git-client
> %_mandir/man1/dist-git-client.1*
> %dir %_sysconfdir/dist-git-client
> %config %_sysconfdir/dist-git-client/default.ini
> %python3_sitelib/dist_git_client.*
> %python3_sitelib/__pycache__/dist_git_client*

There is a small inconsistency with the macro syntax. Here you are using %foo
and in the previous sections %{foo}


Otherwise LGTM


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2293067

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202293067%23c2
--
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to