https://bugzilla.redhat.com/show_bug.cgi?id=2299972

Neal Gompa <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #9 from Neal Gompa <[email protected]> ---
Spec review notes:

> Source:         %{url}/archive/refs/tags/v%{version}.tar.gz

This should use the form "%{url}/archive/v%{version}/%{name}-%{version}.tar.gz"

> cat <<EOF > localconf
> BEES_VERSION=v%{version}
> DEFAULT_MAKE_TARGET=all
> LIBEXEC_PREFIX=%{_libexecdir}/%{name}
> LIB_PREFIX=%{_libdir}
> PREFIX=%{_prefix}
> SYSTEMD_SYSTEM_UNIT_DIR=%{_unitdir}
> EOF

This should be in the "%conf" section in between %prep and %build.

Cf.
https://rpm-software-management.github.io/rpm/manual/spec.html#conf-since-rpm--418


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2299972

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202299972%23c9

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to