https://bugzilla.redhat.com/show_bug.cgi?id=2305184
--- Comment #5 from Sandro <[email protected]> --- (In reply to Mithun Veluri from comment #4)further will explore 'tag'. > And yes, I missed to verify list (rpm -qpl) of files which will be installed > via result rpm. Also, even if had verified the files of rpm, I wouldn't have > figured out that staged changes can caused hash to come in version string. > Thanks for pointing that! If you look in /usr/lib/python3.12/site-packages/ you will not see many `*dist-info` directories with a git hash in there. But it's something that's easily missed. Also if upstream is not using any fancy versioning based on VCS, this wouldn't be an issue. > Regarding the tests, my bad, I did misunderstood it as flake, in real there > is an pytest plugin "flaky" which has to be added in BR. Well, almost. It seems you are guessing a bit. Yes the error message mentions `flaky`. But it's not what upstream is using. Upstream uses `pytest-rerunfailures`. It's listed in `setup.cfg` as a dependency for the `test` extra. While the tests succeed with `flaky`, they might break if upstream decides to use a specific feature of `pytest-rerunfailures` that `flaky` does not support. Also we should stay as close to upstream as possible. I encourage you to take another look at `setup.cfg` and try to understand what it does, how it defines dependencies. Last but not least, upstream released a new version a few days ago. I only noticed today when preparing a patch for excluding the tests from the wheel [1]. I think it's useful to apply that patch. If upstream accepts it, it will be in the next release. If not we can keep it as a downstream only patch in order to avoid installing the tests and test data (JSON files). Please also update to the latest release, 0.10.3. [1] https://github.com/dandi/dandi-schema/pull/249 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2305184 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202305184%23c5 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
