https://bugzilla.redhat.com/show_bug.cgi?id=2294379



--- Comment #4 from Elliott Sales de Andrade <[email protected]> ---
(In reply to Peter Lemenkov from comment #3)
> Few notes:
> 
> * I have a header in your package -
> /usr/lib64/python3.13/site-packages/pyogrio/arrow_bridge.h. Not sure what is
> it. Could you elaborate?

It seems likely this is a mistake, but I have asked upstream about it:
https://github.com/geopandas/pyogrio/issues/433#issuecomment-2295434424

> * Interestingly but that header also licensed under a different license -
> ASL 2.0 so your %license field has to be "MIT and Apache-2.0"

I updated the license to include the header license as well for now, and can
drop it later if it goes away.
I also updated the license to include the data files.

> * (Not a blocker) Patches should be commented (like for example "#
> Fedora-specific, nothing to see here") or links to upstream PRs/MRs should
> be provided.

Comments added.

Also added a missing test dependency.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2294379

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202294379%23c4

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to