https://bugzilla.redhat.com/show_bug.cgi?id=2298050



--- Comment #7 from Peng Wu <[email protected]> ---
Here are some suggestions for the spec file.
Please update the spec file and the srpm package, thanks!

Please define the shortcommit macro and use this macro in the following lines.

%global shortcommit %(c=%{commit}; echo ${c:0:7})

Version:        0.1.1^%{snapdate}g%{shortcommit}
Source0:       
%{url}/archive/%{commit}.tar.gz#/chewing-editor-%{shortcommit}.tar.gz

URL:
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_hosting_services

Please update the %changelog section

%autochangelog
- 
=>
%changelog
%autochangelog

Please update the srpm package to use the same spec file in the spec URL.

[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2298050

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202298050%23c7

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to