https://bugzilla.redhat.com/show_bug.cgi?id=2276561

Fabio Valentini <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request:             |Review Request:
                   |rust-onenote_parser -       |rust-onenote_parser -
                   |Parser for Microsoft        |Parser for Microsoft
                   |OneNote® files              |OneNote files
              Flags|fedora-review?              |fedora-review+



--- Comment #16 from Fabio Valentini <[email protected]> ---
> Fabio - thank you very much for the instruction in rust2rpm.toml - I had no 
> idea that existed.

Yeah, it's very useful for storing settings and / or changes that need to
persist across re-generations of the spec file.

I recently added some docs for it in the "rust2rpm.toml(5)" manpage, I hope
they're helpful.

You can also use settings to override the Summary and %description (i.e. to
persist the removal of the ® symbol).

Package looks good to me now!

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2276561

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202276561%23c16

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to